Skip to content

Commit

Permalink
Mark the passing UBSAN build as stable (#536)
Browse files Browse the repository at this point in the history
PR #519 added the "AMD64 Arch Linux Usan Function" UBSAN builder with
-fno-sanitize=function, but made it unstable and left the existing
USAN builder with all checks as stable.

We currently need this skip in order to pass, so the Function one
should be marked stable (until gh-111178 is fixed & we can merge
the two builders again).
  • Loading branch information
encukou authored Oct 8, 2024
1 parent be039fa commit ad0c1f8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions master/custom/builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,12 @@
# Special builds: FIPS, ASAN, UBSAN, TraceRefs, Perf, etc.
("AMD64 RHEL8 FIPS Only Blake2 Builtin Hash", "cstratak-RHEL8-fips-x86_64", RHEL8NoBuiltinHashesUnixBuildExceptBlake2),
("AMD64 Arch Linux Asan", "pablogsal-arch-x86_64", UnixAsanBuild),
("AMD64 Arch Linux Usan", "pablogsal-arch-x86_64", ClangUbsanLinuxBuild),
("AMD64 Arch Linux Asan Debug", "pablogsal-arch-x86_64", UnixAsanDebugBuild),
("AMD64 Arch Linux TraceRefs", "pablogsal-arch-x86_64", UnixTraceRefsBuild),
("AMD64 Arch Linux Perf", "pablogsal-arch-x86_64", UnixPerfBuild),
# UBSAN with -fno-sanitize=function, without which we currently fail (as
# tracked in gh-111178). The full "AMD64 Arch Linux Usan" is unstable, below
("AMD64 Arch Linux Usan Function", "pablogsal-arch-x86_64", ClangUbsanFunctionLinuxBuild),

# Linux x86 (32-bit) GCC
("x86 Debian Non-Debug with X", "ware-debian-x86", NonDebugUnixBuild),
Expand Down Expand Up @@ -281,8 +283,8 @@
# riscv64 GCC
("riscv64 Ubuntu23", "onder-riscv64", SlowUnixInstalledBuild),

# Arch Usan Function
("AMD64 Arch Linux Usan Function", "pablogsal-arch-x86_64", ClangUbsanFunctionLinuxBuild),
# Arch Usan (see stable "AMD64 Arch Linux Usan Function" above)
("AMD64 Arch Linux Usan", "pablogsal-arch-x86_64", ClangUbsanLinuxBuild),
]


Expand Down

0 comments on commit ad0c1f8

Please sign in to comment.