Fix some test failures on openssl 1.1.1 / Ubuntu 18.10 #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See python-trio#817 We don't have CI for this yet, but at least on my laptop it helps. However, it doesn't fix everything. - Add OP_ENABLE_MIDDLEBOX_COMPAT to the list of static ssl constants - Handle SSLZeroReturnError in more places - Fix some -- but not all -- of the places where session tickets cause failures. See python-trio#819
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 99.01% 98.97% -0.04%
==========================================
Files 94 94
Lines 11631 11643 +12
Branches 832 833 +1
==========================================
+ Hits 11516 11524 +8
- Misses 94 97 +3
- Partials 21 22 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 99.01% 95.75% -3.26%
==========================================
Files 94 105 +11
Lines 11631 12789 +1158
Branches 832 1016 +184
==========================================
+ Hits 11516 12246 +730
- Misses 94 507 +413
- Partials 21 36 +15
Continue to review full report at Codecov.
|
|
Closing in favor of #841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #817
We don't have CI for this yet, but at least on my laptop it helps.
However, it doesn't fix everything.
failures. See Deadlocks caused by openssl's handling of TLS 1.3 session tickets #819
Not sure if we should merge this as is, to at least cut down some of
the issues, or wait to try to deal with more of the session ticket
mess...