Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Pytest's warning #2651

Merged
merged 1 commit into from
May 29, 2023
Merged

Ignore Pytest's warning #2651

merged 1 commit into from
May 29, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented May 26, 2023

This is a temporary change until pytest-dev/pytest#10894 is merged. cc @jakkdl

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #2651 (b136fa6) into master (b21d4b9) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head b136fa6 differs from pull request most recent head f5c4466. Consider uploading reports for the commit f5c4466 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2651      +/-   ##
==========================================
+ Coverage   91.51%   91.74%   +0.23%     
==========================================
  Files         118      118              
  Lines       16444    16444              
  Branches     2970     2970              
==========================================
+ Hits        15048    15086      +38     
+ Misses       1275     1244      -31     
+ Partials      121      114       -7     

see 11 files with indirect coverage changes

@A5rocks A5rocks force-pushed the ignore-pytest-warning branch from b136fa6 to d54c84b Compare May 26, 2023 02:47
@jakkdl
Copy link
Member

jakkdl commented May 26, 2023

Oh boi, with it exiting alpha now all the static tool tests are let loose.

How about marking all the currently failings tests with xfail on 3.12 so the CI passes? We can still track them more properly in #2646 but I imagine it'll be a while until all tests are passing on 3.12

@pytest.mark.xfail(sys.version_info[:2] == (3, 12), reason="blabla")

@A5rocks
Copy link
Contributor Author

A5rocks commented May 27, 2023

I'll do that in a separate PR. I suspect the largest diff will be fixed in the next upgrade of typing extensions (on June 1st we'll have our autodeps thing run) and for the rest, dunno.

@A5rocks
Copy link
Contributor Author

A5rocks commented May 28, 2023

OK I got a bit impatient, #2652 should fix some stuff here

@A5rocks A5rocks force-pushed the ignore-pytest-warning branch from d54c84b to f5c4466 Compare May 28, 2023 23:13
@A5rocks
Copy link
Contributor Author

A5rocks commented May 29, 2023

To be blunt: I would like this merged before working on xfail-ing, fixing things, etc.

More generally I am of the opinion that we shouldn't xfail stuff that we plan to fix soon-ish but I want to investigate the errors a bit. Static stuff should be quick to fix, changes in cpython impl details not so much.

@jakkdl jakkdl merged commit 6e8c2af into master May 29, 2023
@jakkdl jakkdl deleted the ignore-pytest-warning branch May 29, 2023 12:24
@A5rocks A5rocks mentioned this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants