Workaround OpenSSL 1.1.1 session-ticket issue #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
- Coverage 99.55% 92.62% -6.94%
==========================================
Files 106 106
Lines 12751 12767 +16
Branches 978 980 +2
==========================================
- Hits 12694 11825 -869
- Misses 36 877 +841
- Partials 21 65 +44
|
|
The remaining test failure should be fixed by #1172 |
|
Not sure why codecov isn't updating its comment. If you click through then it says that everything is covered. |
pquentin
reviewed
Aug 2, 2019
| @@ -40,7 +40,10 @@ class FakeHostnameResolver(trio.abc.HostnameResolver): | |||
|
|
|||
|
|
|||
| # This uses serve_ssl_over_tcp, which uses open_ssl_over_tcp_listeners... | |||
| async def test_open_ssl_over_tcp_stream_and_everything_else(): | |||
| # noqa is needed because flake8 doesn't understand how pytest fixtures work. | |||
There was a problem hiding this comment.
I think you can fix the flake8 issue by removing the unused client_ctx import
There was a problem hiding this comment.
It's not unused, it's making the fixture function visible to pytest...
There was a problem hiding this comment.
Sorry about that, I'm used to projects where pytest discovers the fixtures through conftest.py
|
I'm a big fan of the analysis on #819 - thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819