Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 GitHub action #522

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 10, 2020

Proposed changes

It lints code base with flake8 and adds GitHub annotations for errors.

There are currently lots of errors raised. I can fix the code as well, given there is consensus this is the right coding style tool (and probably after merging other pending pull requests to avoid excessive merge conflicts).

Types of changes

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Discussed in #445

It lints code base with flake8 and adds GitHub annotations for errors.
@stale
Copy link

stale bot commented Jan 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues (closing soon) label Jan 9, 2021
@nijel
Copy link
Member Author

nijel commented Jan 9, 2021

ping

@stale stale bot removed the stale Stale issues (closing soon) label Jan 9, 2021
@omab
Copy link
Contributor

omab commented Jan 9, 2021

Let's give this a try, thanks!

@omab omab merged commit e0bbe8a into python-social-auth:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants