Change WorkspaceEdit to use documentChanges
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also extract out _rope_changeset_to_workspace_edit_with_changes() and _get_contents().
9dee032 to
40c9c8d
Compare
… WorkspaceEditWithDocumentChanges
…ument This argument selects between returning WorkspaceEditWithChanges or WorkspaceEditWithDocumentChanges variants of WorkspaceEdit.
We need to upgrade this at some point.
5e259a6 to
0d32835
Compare
2935d13 to
adab2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two variants of
WorkspaceEdit, this change generates theWorkspaceEdit.documentChangesand converts it tochangesfor clients that doesn't supportdocumentChanges.Whether a client supports versioned document edits is expressed via wworkspace.workspaceEdit.documentChanges` client capability.