-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(install): add --all-groups
flag to install all dependency groups
#9744
feat(install): add --all-groups
flag to install all dependency groups
#9744
Conversation
… for installation
Please review, feedback welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @radoering, care to take a look?
I will take a look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There is just one thing: python-poetry/poetry-plugin-export#294 introduces --all-groups
to poetry export
(not yet released). It is the same name; that is good. However, in poetry export
--all-groups
conflicts with --with
and --without
. I have no clear preference, but we should make it consistent.
Thanks for reviewing. |
Deploy preview for website ready! ✅ Preview Built with commit 0b0c838. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds the
--all-groups
flag topoetry install
which includes all the dependency groups (including optional groups) for installation. This is a very common use case for projects with multiple optional groups and allows the user to install everything without specifying each group.This feature has been discussed in the past. See e.g. #7605 and #5461. I gave it another shot with an implementation that respects the existing options and flags.
I decided not to go with
--with=all
or similar and instead use the explicit flag--all-groups
, consistent with the--all-extras
flag. A naming alternative would be--with-all
.Options like
--all-groups --without=docs
are supported,--all-groups --with=foo
ignores thewith
with a warning,--all-groups --only=foo
results in an error.Pull Request Check List