ABC (Abstract Base Class) fixups #9719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasePlugin contains @AbstractMethod without inheriting from ABC. Without ABC, @AbstractMethod has no effect. Fix by letting BasePlugin inherit from ABC.
ConfigSource appears to be used as an ABC, yet uses an older Python pattern: its abstract methods raise NotImplementedError(). Improve by making ConfigSource inherit from ABC, and use @AbstractMethod to mark its abstract methods.
Formatter appears to be used as an ABC, yet uses an older Python pattern: its abstract methods raise NotImplementedError(). Improve by making the class inherit from ABC, and use @AbstractMethod to mark its abstract methods.
Operation appears to be used as an ABC, yet uses an older Python pattern: its abstract methods raise NotImplementedError(). Improve by making the class inherit from ABC, and use @AbstractMethod to mark its abstract methods.
Env appears to be used as an ABC, yet uses an older Python pattern: its abstract methods raise NotImplementedError(). Improve by making the class inherit from ABC, and use @AbstractMethod to mark its abstract methods.
radoering
approved these changes
Sep 29, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry doesn't always use the ABC pattern where appropriate, and where used, not always consistently. Fix that up.