Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove local version specifier at poetry add #9603

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Aug 3, 2024

$ poetry source add torch https://download.pytorch.org/whl/cpu
Adding source with name torch.

$ poetry add --lock --source torch torch
Using version ^2.4.0+cpu for torch

but ^2.4.0+cpu is not a valid constraint: or anyway it is not valid once it has been converted into a regular version specifier (eg when written to METADATA). Because per PEP440 on inclusive ordered comparison

Local version identifiers are NOT permitted in this version specifier

@dimbleby dimbleby force-pushed the invalid-constraint branch from 11943a6 to c6de190 Compare August 3, 2024 21:40
@radoering radoering merged commit 3ea8a5d into python-poetry:main Aug 15, 2024
75 checks passed
@dimbleby dimbleby deleted the invalid-constraint branch August 15, 2024 15:19
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants