Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xattr version for darwin #8702

Closed
wants to merge 2 commits into from

Conversation

mrmeszaros
Copy link
Contributor

Resolves: #8528

Bumping the version fixes the missing xattr/lib_build.h file issue.

I have one question: is this lib only needed for osx / darwin?
If yes - I would like to remove the TODO comment
If not - I would like to test this for other sys_platforms

@Secrus
Copy link
Member

Secrus commented Nov 23, 2023

There is a TODO comment here that explains why this comment is there. If you want to explore that further, feel free to do it and submit a PR, but it would be out of scope for this PR here.

EDIT: At first I didn't notice that it was your TODO left in pyproject.toml. Anyway, my point stands, if you want to make xattr (and the features we use it for) cross-platform, feel free to submit PR, otherwise you can just remove the TODO from pyproject.toml.

@Secrus
Copy link
Member

Secrus commented Dec 17, 2023

@mrmeszaros I have opened #8801 since I had some problems fixing issues in your PR. I added you as co-author to commit in my PR, I hope you don't mind.

@Secrus Secrus closed this Dec 17, 2023
@mrmeszaros
Copy link
Contributor Author

@Secrus I had a bigger load on my day job and did not have the time to check back till now.

So Thank You :)

Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xattr/lib_build.h file not getting installed with poetry installation
2 participants