Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a grammatic error in the documentation #6762

Closed

Conversation

sadatyussuf
Copy link

Pull Request Check List

Resolves: #3060

  • Added tests for changed code.
  • Updated documentation for changed code.

@neersighted
Copy link
Member

neersighted commented Oct 10, 2022

Hi @sadatyussuf, thanks for your interest in contributing! Unfortunately, this PR is not mergable:

  • Most of it is changing syntax for seemingly no reason -- without tooling to enforce one syntax or another, a PR that just changes the docs with zero substance is unlikely to be accepted.
  • The only grammar change is incorrect.
  • The PR claims it Resolves: the permanent issue when it should be Relates-to:.

If you're interested in making these syntax changes (and dropping the bad grammar change), feel free to use pre-commit to enforce some normalization of our markdown files. But until then, I think we'll decline any syntax-only changes.

@sadatyussuf
Copy link
Author

Thanks for the feedback, this is my first ever contribution and I messed it up. I'm very sorry

@sadatyussuf sadatyussuf deleted the typo-docs-contributing branch October 10, 2022 20:18
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Documentation contributions
2 participants