Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EditableBuilder ignoring error in build script #6183

Closed
wants to merge 1 commit into from

Conversation

touilleMan
Copy link

Pull Request Check List

Resolves: #6182

@qualiaa
Copy link

qualiaa commented Mar 16, 2023

I believe this will fix the issue, but what was the purpose of specifying call=True in the first place? If it serves some deeper purpose, then an alternative fix would be to throw an exception if the return value of env.run is non-zero. This is the process returncode, returned from call here:

return subprocess.call(

@dimbleby
Copy link
Contributor

superseded by #7812, please close

@Secrus Secrus closed this Oct 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry install ignore build script failure
4 participants