-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code #6097
Remove dead code #6097
Conversation
This might also be useful: https://github.com/asottile/dead |
7173c53
to
5663421
Compare
a214ef3
to
ce78cfb
Compare
I'm dubious on all code removed here being dead (e.g. I used some of the removed |
ce78cfb
to
7c10c83
Compare
7c10c83
to
5e1a0ea
Compare
5e1a0ea
to
f7e983b
Compare
f7e983b
to
e07ecbb
Compare
e07ecbb
to
0dad7ff
Compare
0dad7ff
to
0d60ae2
Compare
0d60ae2
to
f0c067c
Compare
f0c067c
to
143045a
Compare
39cbf2b
to
f5df3f7
Compare
f5df3f7
to
7b56699
Compare
18 months later it all still is unused |
@dimbleby if you could rebase the changes with the latest |
7b56699
to
0de87b1
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I thought I'd have a go with https://pypi.org/project/vulture/
It reports rather a lot of false positives and I doubt that it's going to be worth the trouble of maintaining an allowlist and running this in pipelines: but as a one-off thing I reckon it did find a fair amount that can sensibly be removed - per this MR.
Less code = less bugs!