Backport PR #3337 - Fix handling errors 401, 403 when looking for repositories #5224
Conversation
Resolves: #3303
There was a problem hiding this comment.
Jesus, why didn't anybody fix this before or has approved this merge earlier?
As is, the code handling 401 and 403 exceptions is inaccessible, hence should either be removed or moved before exception is raised to be actually functional. I lean heavily towards handling 40x exceptions instead of raising them and causing entire build process go to hell because somebody either forgot to log in or (more likely) you are trying to find non-existent packages in a private repository that returns 403 instead of 404 (looking at you pytorch...).
|
Poetry team won't do another 1.1.x release, so this PR is no longer valid. Closing. |
|
Ok, thank you for clarification. I was not up to date with release schedule of poetry, since the 1.1.x is still the default version when looking for docs (https://python-poetry.org/docs/). Perhaps it'd be a good idea to point towards 1.2 as a recommended release (even if it's only in preview). |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Backport of #3337 which fixes #3303 to the 1.1 branch, so that it can be part of the next 1.1.x release 🙂
/cc @finswimmer