Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm not really sure of what I fixed #1700

Closed
wants to merge 1 commit into from
Closed

I'm not really sure of what I fixed #1700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions poetry/version/markers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,12 @@ def without_extras(self):

return MarkerUnion(*new_markers)

def is_any(self): # type: () -> bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed/added this in 1.0.0b9 can you try again on the latest release?

PR: #1650

Copy link
Author

@Steffo99 Steffo99 Dec 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying immediately!

Copy link
Contributor

@JBKahn JBKahn Dec 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to re-lock as the previous versions created issues with the lockfile because of that (as opposed to calling update).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working perfectly! Thanks! :D

for marker in self.markers:
if not marker.is_any():
return False
return True

def __eq__(self, other):
if not isinstance(other, MarkerUnion):
return False
Expand Down