Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'poetry init' should use existing pyproject.toml file #1639

Closed
2 tasks done
dekoza opened this issue Nov 27, 2019 · 4 comments · Fixed by #2448
Closed
2 tasks done

'poetry init' should use existing pyproject.toml file #1639

dekoza opened this issue Nov 27, 2019 · 4 comments · Fixed by #2448
Assignees
@finswimmer
Labels
kind/feature Feature requests/implementations

Comments

@dekoza
Copy link

dekoza commented Nov 27, 2019

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

I think that poetry init should detect if existing pyproject.toml already contains poetry entries and if not, it should add itself to it instead of exiting with error. I have basic (almost brute-force) method prepared but I want to make it in more elegant way. Anyway, expect PR soon 😄
@dekoza dekoza added the kind/feature Feature requests/implementations label Nov 27, 2019
@finswimmer
Copy link
Member

Hello @dekoza ,

sounds like a good idea to me 👍

I would really like to see your PR :)

fin swimmer

@ttimbers
Copy link

I would like to see this feature too! It would be very helpful when paired with Cookiecutter templates.

@ttimbers ttimbers mentioned this issue Feb 19, 2020
Closed
@dekoza
Copy link
Author

dekoza commented Feb 20, 2020

I'm sorry, my commercial project really eats up a lot of my time lately. If anyone wants to take over, don't hesitate 🙂

@finswimmer finswimmer self-assigned this May 17, 2020
@finswimmer finswimmer mentioned this issue May 21, 2020
Merged
@abn abn closed this as completed in #2448 Sep 29, 2020
abn pushed a commit that referenced this issue Sep 29, 2020
@finswimmer
init: reuse existing pyproject.toml when safe (#2448)
30a9b13 
At the moment a `poetry init` will fail, if a pyproject.toml already
exists. This change ensures pyproject.toml is reused if no build-system
has already been defined or poetry is not already configured.

Resolves: #1639
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@finswimmer finswimmer

Labels
kind/feature Feature requests/implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

poetry init uses existing pyproject.toml if possible finswimmer/poetry
3 participants
@dekoza @finswimmer @ttimbers