-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawns a shell within the virtualenv #134
Comments
|
Perfect! I didn't think to test that… |
I'd like to see this reopened. It would be neat to have this as a convenient shortcut. After all, poetry already knows what my shell is, so why do I need to tell it again? |
I reopen and let @sdispater decide what to do of this. |
@NotAFile how does poetry already know what your shell is? |
@bertjwregeer through the |
@NotAFile which may or may not be set, and may or may not be set to the correct shell... |
@bertjwregeer Sure. Alternatives would have to be found for Windows. It's probably worth looking at how similar projects handle this. For *NIX I don't see anything wrong with using $SHELL. It's set by your shell, and if your shell doesn't know what shell it is, perhaps you have bigger problems... Even then, if someone has an extremely weird setup where SHELL is somehow not the shell, it's not like the trusty normal "run" command wouldn't still be there. |
Hey, this is being implemented - check out #198 :) |
This feature is being worked on in #201 and I'll happy to hear your feedback. If you know something about Windows and are willing to help, I'd like to be able to know how to properly detect the correct shell, if it's not |
@cauebs, re better Windows support, the best option is to use what pipenv patched pew to do https://github.com/pypa/pipenv/blob/master/pipenv/patched/pew/_win_utils.py. Sadly you have to enumerate all processes to find your parent :/ |
|
Awesome! Poetry is now my tool of choice. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It would be nice to have a command
poetry shell
that acts likepipenv shell
, instead of having tosource ~/.cache/pypoetry/…/bin/activate
.The text was updated successfully, but these errors were encountered: