go with test suggestion

tests/console/commands/env/conftest.py

@@ -20,7 +20,7 @@
 def venv_name(app: PoetryTestApplication) -> str:
     return EnvManager.generate_env_name(
         app.poetry.package.name,
-        str(app.poetry.file.path.parent),
+        str(app.poetry.file.parent),
     )
 
 
@@ -58,7 +58,7 @@ def venvs_in_cache_dirs(
 @pytest.fixture
 def venvs_in_project_dir(app: PoetryTestApplication) -> Iterator[Path]:
     os.environ.pop("VIRTUAL_ENV", None)
-    venv_dir = app.poetry.file.path.parent.joinpath(".venv")
+    venv_dir = app.poetry.file.parent.joinpath(".venv")
     venv_dir.mkdir(exist_ok=True)
     app.poetry.config.merge({"virtualenvs": {"in-project": True}})
 
@@ -71,7 +71,7 @@ def venvs_in_project_dir(app: PoetryTestApplication) -> Iterator[Path]:
 @pytest.fixture
 def venvs_in_project_dir_none(app: PoetryTestApplication) -> Iterator[Path]:
     os.environ.pop("VIRTUAL_ENV", None)
-    venv_dir = app.poetry.file.path.parent.joinpath(".venv")
+    venv_dir = app.poetry.file.parent.joinpath(".venv")
     venv_dir.mkdir(exist_ok=True)
     app.poetry.config.merge({"virtualenvs": {"in-project": None}})
 
@@ -84,7 +84,7 @@ def venvs_in_project_dir_none(app: PoetryTestApplication) -> Iterator[Path]:
 @pytest.fixture
 def venvs_in_project_dir_false(app: PoetryTestApplication) -> Iterator[Path]:
     os.environ.pop("VIRTUAL_ENV", None)
-    venv_dir = app.poetry.file.path.parent.joinpath(".venv")
+    venv_dir = app.poetry.file.parent.joinpath(".venv")
     venv_dir.mkdir(exist_ok=True)
     app.poetry.config.merge({"virtualenvs": {"in-project": False}})
 

tests/console/commands/test_add.py

@@ -15,7 +15,6 @@
 from poetry.console.commands.installer_command import InstallerCommand
 from poetry.puzzle.exceptions import SolverProblemError
 from poetry.repositories.legacy_repository import LegacyRepository
-from tests.helpers import TestLocker
 from tests.helpers import get_dependency
 from tests.helpers import get_package
 
@@ -1507,36 +1506,3 @@ def test_add_extras_only_accepts_one_package(
             str(e.value)
             == "You can only specify one package when using the --extras option"
         )
-
-
-@pytest.mark.parametrize("command", ["foo", "foo --lock"])
-@pytest.mark.parametrize(
-    ("locked", "expected_docker"), [(True, "4.3.1"), (False, "4.3.2")]
-)
-def test_add_does_not_update_locked_dependencies(
-    repo: TestRepository,
-    poetry_with_up_to_date_lockfile: Poetry,
-    tester: CommandTester,
-    command_tester_factory: CommandTesterFactory,
-    command: str,
-    locked: bool,
-    expected_docker: str,
-) -> None:
-    assert isinstance(poetry_with_up_to_date_lockfile.locker, TestLocker)
-    poetry_with_up_to_date_lockfile.locker.locked(locked)
-    tester = command_tester_factory("add", poetry=poetry_with_up_to_date_lockfile)
-    docker_locked = get_package("docker", "4.3.1")
-    docker_new = get_package("docker", "4.3.2")
-    docker_dep = get_dependency("docker", ">=4.0.0")
-    foo = get_package("foo", "0.1.0")
-    foo.add_dependency(docker_dep)
-    for package in docker_locked, docker_new, foo:
-        repo.add_package(package)
-
-    tester.execute(command)
-
-    lock_data = poetry_with_up_to_date_lockfile.locker.lock_data
-    docker_locked_after_command = next(
-        p for p in lock_data["package"] if p["name"] == "docker"
-    )
-    assert docker_locked_after_command["version"] == expected_docker

tests/console/commands/test_install.py

@@ -419,10 +419,9 @@ def test_install_logs_output_decorated(
 
 @pytest.mark.parametrize("options", ["", "--without dev"])
 @pytest.mark.parametrize(
-    "project",
-    ["missing_directory_dependency_from_group", "missing_file_dependency_from_group"],
+    "project", ["missing_directory_dependency", "missing_file_dependency"]
 )
-def test_install__dependency_does_not_exist(
+def test_install_path_dependency_does_not_exist(
     command_tester_factory: CommandTesterFactory,
     project_factory: ProjectFactory,
     fixture_dir: FixtureDirGetter,
@@ -438,3 +437,23 @@ def test_install__dependency_does_not_exist(
     else:
         with pytest.raises(ValueError, match="does not exist"):
             tester.execute(options)
+
+
+@pytest.mark.parametrize("options", ["", "--no-directory"])
+def test_install_missing_directory_dependency_with_no_directory(
+    command_tester_factory: CommandTesterFactory,
+    project_factory: ProjectFactory,
+    fixture_dir: FixtureDirGetter,
+    options: str,
+) -> None:
+    poetry = _project_factory(
+        "missing_directory_dependency", project_factory, fixture_dir
+    )
+    assert isinstance(poetry.locker, TestLocker)
+    poetry.locker.locked(True)
+    tester = command_tester_factory("install", poetry=poetry)
+    if options:
+        tester.execute(options)
+    else:
+        with pytest.raises(ValueError, match="does not exist"):
+            tester.execute(options)

tests/console/commands/test_lock.py

@@ -208,7 +208,7 @@ def test_lock_no_update_path_dependencies(
 @pytest.mark.parametrize(
     "project", ["missing_directory_dependency", "missing_file_dependency"]
 )
-def test_lock_path_dependency_does_not_exist_and_was_removed_from_pyproject(
+def test_lock_path_dependency_does_not_exist(
     command_tester_factory: CommandTesterFactory,
     project_factory: ProjectFactory,
     fixture_dir: FixtureDirGetter,

tests/console/commands/test_remove.py

@@ -10,7 +10,6 @@
 from poetry.core.packages.package import Package
 
 from poetry.factory import Factory
-from tests.helpers import TestLocker
 from tests.helpers import get_package
 
 
@@ -34,16 +33,12 @@ def poetry_with_up_to_date_lockfile(
 ) -> Poetry:
     source = fixture_dir("up_to_date_lock")
 
-    poetry = project_factory(
+    return project_factory(
         name="foobar",
         pyproject_content=(source / "pyproject.toml").read_text(encoding="utf-8"),
         poetry_lock_content=(source / "poetry.lock").read_text(encoding="utf-8"),
     )
 
-    assert isinstance(poetry.locker, TestLocker)
-    poetry.locker.locked(True)
-    return poetry
-
 
 @pytest.fixture()
 def tester(command_tester_factory: CommandTesterFactory) -> CommandTester:
@@ -54,6 +49,7 @@ def test_remove_without_specific_group_removes_from_all_groups(
     tester: CommandTester,
     app: PoetryTestApplication,
     repo: TestRepository,
+    command_tester_factory: CommandTesterFactory,
     installed: Repository,
 ) -> None:
     """
@@ -112,6 +108,7 @@ def test_remove_without_specific_group_removes_from_specific_groups(
     tester: CommandTester,
     app: PoetryTestApplication,
     repo: TestRepository,
+    command_tester_factory: CommandTesterFactory,
     installed: Repository,
 ) -> None:
     """
@@ -169,6 +166,7 @@ def test_remove_does_not_live_empty_groups(
     tester: CommandTester,
     app: PoetryTestApplication,
     repo: TestRepository,
+    command_tester_factory: CommandTesterFactory,
     installed: Repository,
 ) -> None:
     """
@@ -215,6 +213,7 @@ def test_remove_canonicalized_named_removes_dependency_correctly(
     tester: CommandTester,
     app: PoetryTestApplication,
     repo: TestRepository,
+    command_tester_factory: CommandTesterFactory,
     installed: Repository,
 ) -> None:
     """
@@ -309,47 +308,3 @@ def test_remove_with_dry_run_keep_files_intact(
     assert (
         poetry_with_up_to_date_lockfile._locker.lock_data == original_lockfile_content
     )
-
-
-def test_remove_performs_uninstall_op(
-    poetry_with_up_to_date_lockfile: Poetry,
-    command_tester_factory: CommandTesterFactory,
-    installed: Repository,
-) -> None:
-    installed.add_package(get_package("docker", "4.3.1"))
-    tester = command_tester_factory("remove", poetry=poetry_with_up_to_date_lockfile)
-
-    tester.execute("docker")
-
-    expected = """\
-Updating dependencies
-Resolving dependencies...
-
-Package operations: 0 installs, 0 updates, 1 removal
-
-  • Removing docker (4.3.1)
-
-Writing lock file
-"""
-
-    assert tester.io.fetch_output() == expected
-
-
-def test_remove_with_lock_does_not_perform_uninstall_op(
-    poetry_with_up_to_date_lockfile: Poetry,
-    command_tester_factory: CommandTesterFactory,
-    installed: Repository,
-) -> None:
-    installed.add_package(get_package("docker", "4.3.1"))
-    tester = command_tester_factory("remove", poetry=poetry_with_up_to_date_lockfile)
-
-    tester.execute("docker --lock")
-
-    expected = """\
-Updating dependencies
-Resolving dependencies...
-
-Writing lock file
-"""
-
-    assert tester.io.fetch_output() == expected

tests/fixtures/missing_directory_dependency/pyproject.toml

@@ -8,4 +8,6 @@ packages = []
 
 [tool.poetry.dependencies]
 python = "*"
+
+[tool.poetry.dev-dependencies]
 missing = { path = "./missing" }

tests/fixtures/missing_file_dependency/pyproject.toml

@@ -0,0 +1,13 @@
+[tool.poetry]
+name = "project-with-missing-directory-dependency"
+version = "1.2.3"
+description = "This is a description"
+authors = ["Your Name <you@example.com>"]
+license = "MIT"
+packages = []
+
+[tool.poetry.dependencies]
+python = "*"
+
+[tool.poetry.dev-dependencies]
+missing = { file = "missing-0.1.0-py2.py3-none-any.whl" }