convert_script_files does not require script to exist #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
radoering
reviewed
Feb 24, 2024
| @@ -364,16 +364,6 @@ def convert_script_files(self) -> list[Path]: | |||
|
|
|||
| abs_path = Path.joinpath(self._path, source) | |||
|
|
|||
| if not abs_path.exists(): | |||
There was a problem hiding this comment.
We could put this under if not self._package.build_script: to keep the validation. Without a build script I assume the files must exist at this point.
There was a problem hiding this comment.
@radoering in #710 I am doing this, with added test case, @dimbleby encouraged me to take over. Please review 🙏
weisslj
added a commit
to weisslj/poetry-core
that referenced
this pull request
Mar 10, 2024
… build_script is used python-poetry#699 (comment)
This was referenced Mar 10, 2024
convert_script_files does not require script to exist if build_script is used
dimbleby/poetry-core#1
Closed
|
Superseded by #710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts can be generated during build. But poetry-core insists that scripts exist ahead of time.
fixes python-poetry/poetry#8856
obviously this is giving up some validation: it is now possible to build a wheel that points at a non-existent script. But