Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.1.0a1 #151

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Release 1.1.0a1 #151

merged 2 commits into from
Mar 30, 2021

Conversation

sdispater
Copy link
Member

Changed

  • Dropped support for Python 2.7 and 3.5 (#131).
  • Reorganized imports internally to improve performances (#131).
  • Directory dependencies are now in non-develop mode by default (#98).
  • Improved support for PEP 440 specific versions that do not abide by semantic versioning (#140).

Fixed

  • Fixed path dependencies PEP 508 representation (#141).

@sdispater sdispater requested a review from a team March 30, 2021 12:30
abn
abn previously approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion regarding deprecation note. Otherwise lgtm.

CHANGELOG.md

### Changed

- Dropped support for Python 2.7 and 3.5 ([#131](https://github.com/python-poetry/poetry-core/pull/131)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a note for projects still needing this should use an appropriate build requires section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I just added a note to the change log.

@sdispater sdispater merged commit 4a2ccc3 into master Mar 30, 2021
@sdispater sdispater deleted the release-1.1.0a1 branch March 30, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abn abn abn approved these changes

Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdispater @abn