Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-system.requires entries to dev-dependencies #116

Closed

Conversation

filmor
Copy link

@filmor filmor commented Nov 30, 2020

Resolves: python-poetry#3428

  • Added tests for changed code.
  • Updated documentation for changed code.

@sinoroc
Copy link

sinoroc commented Nov 30, 2020

I am really not sure this is something that is really needed, not as long as custom build steps are not supported.

It's true there is unofficial, undocumented, partial support, but id doesn't count, does it?

If such a feature were to be added, I personally think it should be opt-in, it should be deactivated by default and could be activated by a user setting somewhere, somehow.

@filmor
Copy link
Author

filmor commented Dec 1, 2020

This PR is very similar to #58, I didn't see that before.

@filmor filmor closed this Feb 18, 2022
@filmor filmor deleted the include-build-system-requires branch February 18, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should by default add build-system.requires entries as dev-dependencies
2 participants