-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows build with pyproject.toml #7230
Merged
+86
−120
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
26e0c81
Revert "Install setuptools on Windows"
hugovk 454dfcc
Add minimal pyproject.toml
hugovk 18960e8
Use latest setuptools 67.8
hugovk 9ea7721
Replace direct invocation of setup.py
hugovk 3a0881d
Disable extra quotes
hugovk 58b8d6c
Upgrade pip
hugovk 7f0c49a
Move pip upgrade to .appveyor.yml
hugovk d5e03cc
Wrap arguments before passing
hugovk c068af7
Merge remote-tracking branch 'upstream/main' into add-pyproject.toml
nulano 5d0e37e
use --config-settings when building on Windows
nulano 466aa7e
update winbuild documentation
nulano 14ae3e4
Updated pyproject-fmt to 0.12.1
radarhere 25c24a8
Removed unused code
radarhere c179962
lint fixes
nulano 10ad87c
Merge branch 'main' into add-pyproject.toml
radarhere fec793d
don't explicitly install wheel
nulano b2d7f1e
Merge branch 'main' into add-pyproject.toml
radarhere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,9 @@ | ||
[build-system] | ||
requires = ["setuptools >= 40.8.0", "wheel"] | ||
build-backend = "backend" | ||
backend-path = ["_custom_build"] | ||
requires = [ | ||
"setuptools>=67.8", | ||
"wheel", | ||
] | ||
backend-path = [ | ||
"_custom_build", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The egg format is newly deprecated on PyPI:
I know we're not uploading these, but do we need them here?
(Non-blocking for merge.)