Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: Test on Python 3.9 final #5014

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 27, 2020

Fixes #4953.

Changes proposed in this pull request:

  • AppVeyor now supports Python 3.9 final
  • It requires the Visual Studio 2019 image (also works for 3.6)
  • And the setuptools bump
  • Python 3.9 appveyor/ci#3541

(It's like buses. You wait for ages and then two come along at once.)

@hugovk hugovk added the Testing label Oct 27, 2020
@hugovk hugovk mentioned this pull request Oct 27, 2020
11 tasks
@hugovk hugovk added the Windows label Oct 27, 2020
@nulano
Copy link
Contributor

nulano commented Oct 27, 2020

(It's like buses. You wait for ages and then two come along at once.)

😄

It requires the Visual Studio 2019 image (also works for 3.6)

Hmm... The idea for using VS2017 was to test the build script against multiple versions of VS.
Maybe wait a bit longer to see if they are planning to add it to the other images appveyor/ci#3541 (comment)?

I currently only have VS2017 installed on my system and it is what I use to compile Pillow, but that doesn't give immediate test results when updating one of the dependencies (to see if the patches need to be updated), especially since I don't always rebuild dependencies when changing branches.

@hugovk
Copy link
Member Author

hugovk commented Oct 27, 2020

Sure, let's wait, we're in no rush to update this, we already have GHA testing 3.9.

If AppVeyor aren't going to put 3.9 on VS2017, maybe 3.9/VS2019 and 3.6/VS2017 is possible?

@nulano
Copy link
Contributor

nulano commented Oct 27, 2020

If AppVeyor aren't going to put 3.9 on VS2017, maybe 3.9/VS2019 and 3.6/VS2017 is possible?

Looks like it is not too difficult: https://www.appveyor.com/docs/build-environment/#using-multiple-images-for-the-same-build

@hugovk
Copy link
Member Author

hugovk commented Oct 27, 2020

Updated!

@nulano
Copy link
Contributor

nulano commented Oct 27, 2020

@hugovk
Copy link
Member Author

hugovk commented Oct 28, 2020

(11 hours later and Travis CI still hasn't finished...)

@radarhere radarhere merged commit a348a97 into python-pillow:master Oct 29, 2020
@radarhere radarhere mentioned this pull request Oct 29, 2020
@hugovk hugovk deleted the appveyor-3.9 branch October 29, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.9
3 participants