Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RU locale #228

Merged
merged 4 commits into from
May 21, 2019
Merged

Add RU locale #228

merged 4 commits into from
May 21, 2019

Conversation

senpos
Copy link
Contributor

@senpos senpos commented Jun 7, 2018

Closes #227

locale.py generated with clock on Windows 10.
Tests are included.

Tested by me on Windows 10 with Python 3.6.4.

Thanks to @creazero for testing on Kubuntu 17.10 with Python 2.7 and 3.6.3.

Seems to be working fine. If you encounter any problems - feel free to update related issue or this PR.

@senpos
Copy link
Contributor Author

senpos commented Jun 7, 2018

Due to the Changelog:

diff_for_humans() now returns a few seconds where appropriate.

Is it now required for translations as well?

As I can see, not all current translations use this feature, but it is quite easy to implement with:

translations = {
    ...
    'units': {
        'few_second': 'a few seconds'
    },
    ...

Am I right?

@senpos
Copy link
Contributor Author

senpos commented Aug 31, 2018

@sdispater

Hello.

Do I have to change something here, so you could merge it?

The only failing thing is codecov, but it seems like there is nothing related to my changes.

@ariebovenberg ariebovenberg mentioned this pull request Sep 9, 2018
@snurbol
Copy link

snurbol commented Sep 12, 2018

@sdispater
I agree, why you could not merge it?
Failed only coverage, and tests are same as yours.

@andreynovikov
Copy link

andreynovikov commented May 7, 2019

Any chance of it to be merged? @sdispater why are you asking for locale contribution and then do not accept them for almost a year?

@sdispater sdispater merged commit 0962a6e into python-pendulum:master May 21, 2019
@sdispater
Copy link
Collaborator

Thanks! And sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting RU locale from 1.x
4 participants