Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handful of minor fixes #21

Merged
merged 4 commits into from
Jan 5, 2016
Merged

Conversation

SimplicityGuy
Copy link
Contributor

  • Minor refactoring of the kernel driver release
  • Indentation issue for an if/else
  • Bare minimal style changes (there are many more to do here to be pass pylint, pep8, flake8, etc, but this is a start)

alexforencich added a commit that referenced this pull request Jan 5, 2016
@alexforencich alexforencich merged commit 712a818 into python-ivi:master Jan 5, 2016
@SimplicityGuy
Copy link
Contributor Author

Any objections if I do a more extensive PEP8 cleanup?

@alexforencich
Copy link
Contributor

Might as well.

@SimplicityGuy
Copy link
Contributor Author

Ok, I'll get those done as a single PR. Additional features will be a separate PR.

@alexforencich
Copy link
Contributor

What features are you thinking about adding?

@SimplicityGuy
Copy link
Contributor Author

At the moment, none. As we get into using our instruments with python-usbtmc a bit more, we'll see. I have features in python-ivi to add more immediately (such as exposing a timeout property).

@alexforencich
Copy link
Contributor

Gotcha. I am going to go through all of the pull requests over the next couple of weeks and figure out what can be merged and what needs to be modified. There was also one implementing Rigol quirks for usbtmc, I will have to see if I can get that one to apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants