Increase test coverage of the python_format checker
#1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
commented
Jan 17, 2025
| @@ -65,9 +65,6 @@ def _validate_format(format: str, alternative: str) -> None: | |||
| arguments are not interchangeable as `alternative` may contain less | |||
| placeholders if `format` uses named placeholders. | |||
|
|
|||
| The behavior of this function is undefined if the string does not use | |||
There was a problem hiding this comment.
I think this is wrong - python_format happily calls this method when format does not contain any format placeholders (for example when msgid contains them but msgid_plural does not, python_format will still call _validate_format(msgid_plural, msgstr)).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
+ Coverage 91.37% 91.54% +0.17%
==========================================
Files 27 27
Lines 4672 4674 +2
==========================================
+ Hits 4269 4279 +10
+ Misses 403 395 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
akx
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There a few bugs that I found in the
python_formatchecker while working on the linter that I'd like to fix (e.g. one is that it does not validatemsgstr[N]forN >= 2).Though before I start fixing anything, I want to make sure we have the checker fully covered with tests as it would be pretty easy to accidentally introduce other bugs.
cc @akx