Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer LC_MONETARY when formatting currencies #1173

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Prefer LC_MONETARY when formatting currencies #1173

merged 2 commits into from
Jan 29, 2025

Conversation

akx
Copy link
Member

@akx akx commented Jan 14, 2025

POSIX defines the LC_MONETARY category to be used for monetary formatting, hence Babel could be more standards-compliant in this regard.

Closes #1051 (supersedes it).

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (2d8a808) to head (56ef7c7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
+ Coverage   91.37%   91.39%   +0.01%     
==========================================
  Files          27       27              
  Lines        4672     4681       +9     
==========================================
+ Hits         4269     4278       +9     
  Misses        403      403              
Flag Coverage Δ
macos-14-3.10 90.42% <100.00%> (+0.03%) ⬆️
macos-14-3.11 90.36% <100.00%> (+0.03%) ⬆️
macos-14-3.12 90.57% <100.00%> (+0.03%) ⬆️
macos-14-3.13 90.57% <100.00%> (+0.03%) ⬆️
macos-14-3.8 90.29% <100.00%> (+0.04%) ⬆️
macos-14-3.9 90.35% <100.00%> (+0.03%) ⬆️
macos-14-pypy3.10 90.42% <100.00%> (+0.03%) ⬆️
ubuntu-24.04-3.10 90.45% <100.00%> (+0.03%) ⬆️
ubuntu-24.04-3.11 90.38% <100.00%> (+0.03%) ⬆️
ubuntu-24.04-3.12 90.60% <100.00%> (+0.03%) ⬆️
ubuntu-24.04-3.13 90.60% <100.00%> (+0.03%) ⬆️
ubuntu-24.04-3.8 90.31% <100.00%> (+0.04%) ⬆️
ubuntu-24.04-3.9 90.38% <100.00%> (+0.03%) ⬆️
ubuntu-24.04-pypy3.10 90.45% <100.00%> (+0.03%) ⬆️
windows-2022-3.10 90.44% <100.00%> (+0.01%) ⬆️
windows-2022-3.11 90.37% <100.00%> (+0.01%) ⬆️
windows-2022-3.12 90.59% <100.00%> (+0.01%) ⬆️
windows-2022-3.13 90.59% <100.00%> (+0.01%) ⬆️
windows-2022-3.8 90.41% <100.00%> (+0.01%) ⬆️
windows-2022-3.9 90.37% <100.00%> (+0.01%) ⬆️
windows-2022-pypy3.10 90.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review January 14, 2025 16:46
@akx akx requested a review from tomasr8 January 15, 2025 13:09
@tomasr8
Copy link
Member

tomasr8 commented Jan 16, 2025

I'll take a look later today ;)

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have two questions, the rest looks good to me :)

babel/core.py Show resolved Hide resolved
babel/core.py Show resolved Hide resolved
@akx akx force-pushed the lc-monetary-2 branch 2 times, most recently from 2bd0865 to 676fd91 Compare January 29, 2025 06:53
akx and others added 2 commits January 29, 2025 08:53
Also ignore falsy values in `default_locale` args.
Co-authored-by: Alexis Hildebrandt <afh@surryhill.net>
@akx akx merged commit e9c3ef8 into master Jan 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants