-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer LC_MONETARY when formatting currencies #1173
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 91.37% 91.39% +0.01%
==========================================
Files 27 27
Lines 4672 4681 +9
==========================================
+ Hits 4269 4278 +9
Misses 403 403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'll take a look later today ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have two questions, the rest looks good to me :)
2bd0865
to
676fd91
Compare
Also ignore falsy values in `default_locale` args.
Co-authored-by: Alexis Hildebrandt <afh@surryhill.net>
Closes #1051 (supersedes it).