Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant assignment in Catalog.__setitem__ #1167

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jan 11, 2025

AFAICT, this is a noop and can be removed.

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (c2b397e) to head (caecef2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
- Coverage   91.31%   91.31%   -0.01%     
==========================================
  Files          27       27              
  Lines        4654     4653       -1     
==========================================
- Hits         4250     4249       -1     
  Misses        404      404              
Flag Coverage Δ
macos-14-3.10 90.32% <ø> (-0.01%) ⬇️
macos-14-3.11 90.26% <ø> (-0.01%) ⬇️
macos-14-3.12 90.47% <ø> (-0.01%) ⬇️
macos-14-3.13 90.47% <ø> (-0.01%) ⬇️
macos-14-3.8 90.19% <ø> (-0.01%) ⬇️
macos-14-3.9 90.25% <ø> (-0.01%) ⬇️
macos-14-pypy3.10 90.32% <ø> (-0.01%) ⬇️
ubuntu-24.04-3.10 90.35% <ø> (-0.01%) ⬇️
ubuntu-24.04-3.11 90.28% <ø> (-0.01%) ⬇️
ubuntu-24.04-3.12 90.50% <ø> (-0.01%) ⬇️
ubuntu-24.04-3.13 90.50% <ø> (-0.01%) ⬇️
ubuntu-24.04-3.8 90.21% <ø> (-0.01%) ⬇️
ubuntu-24.04-3.9 90.27% <ø> (-0.01%) ⬇️
ubuntu-24.04-pypy3.10 90.35% <ø> (-0.01%) ⬇️
windows-2022-3.10 90.36% <ø> (-0.01%) ⬇️
windows-2022-3.11 90.29% <ø> (-0.01%) ⬇️
windows-2022-3.12 90.51% <ø> (-0.01%) ⬇️
windows-2022-3.13 90.51% <ø> (-0.01%) ⬇️
windows-2022-3.8 90.33% <ø> (-0.01%) ⬇️
windows-2022-3.9 90.29% <ø> (-0.01%) ⬇️
windows-2022-pypy3.10 90.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is!

@akx akx merged commit 8e10fb5 into python-babel:master Jan 13, 2025
26 checks passed
@tomasr8 tomasr8 deleted the setitem branch January 13, 2025 14:39
@akx akx added this to the Babel 2.17 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants