-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling for locale=None
#1164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 27 27
Lines 4638 4654 +16
=======================================
+ Hits 4235 4250 +15
- Misses 403 404 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'll try to take a look later today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I left you some comments :)
Hopefully I didn't miss anything with so many similar changes 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one thing:
This PR improves the handling of
None
as alocale=
argument.Namely:
Locale.parse()
raises for falsy arguments is more descriptive.None
for a public API means "use the default", not "crash on me".None
locale, but I hope that sort of code isn't very popular.Fixes #1156.
Closes #1158 (supersedes it).