-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tzdata as dev dependency and sync with tox.ini #1159
Conversation
@tomasr8 Hi, do you need any additional tests or information before running the workflow tests? |
Not in my power ;) @akx mind enabling the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond the inline note that the dependency should have the same platform marker it had in the tox.ini file (so as to avoid installing it on platforms where it's unnecessary), it would be better to do as I suggested in #1150 (comment), IOW get rid of the duplicated dependency lists altogether.
@akx Thanks for reviewing! I made changes per your feedback. |
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Can we run CI for these changes? |
@akx Would you be able to take a look? Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
- Coverage 91.47% 91.30% -0.18%
==========================================
Files 27 27
Lines 4636 4636
==========================================
- Hits 4241 4233 -8
- Misses 395 403 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of fixing the indentation failures, and reinstating BABEL_TOX_EXTRA_DEPS
(which we need for GitHub Actions). LGTM, thanks, and sorry for the delays. Happy new year!
Summary
Related Issue
Closes #1150
Changes Made
Testing Done
Recreated virtual environment and installed the dependencies using:
Test output matches before and after changes
![image](https://private-user-images.githubusercontent.com/60816885/392621915-12333c7e-71e7-479f-bc5c-60bfa304e9ff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDg1MjIsIm5iZiI6MTczOTQ0ODIyMiwicGF0aCI6Ii82MDgxNjg4NS8zOTI2MjE5MTUtMTIzMzNjN2UtNzFlNy00NzlmLWJjNWMtNjBiZmEzMDRlOWZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDEyMDM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc5ZWJjOGRkMDIwZjg2MzRlNzQ1OGVlMzFhMjRhYzEyMGI5YmM1Y2I4MDkwMDBhNWVhNDQ3OTFjMjVhMTZlZmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hXeUzlKvcIfIeFQ59zRuj-txdVvp7Hg9yhRTjNy6bz4)
Tested on Windows OS