-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent wrapping file locations containing white space #1120
Conversation
Interesting, calling super() inside a list comprehension does not work on python 3.9.. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
+ Coverage 91.27% 91.47% +0.20%
==========================================
Files 27 27
Lines 4619 4636 +17
==========================================
+ Hits 4216 4241 +25
+ Misses 403 395 -8 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rebased and fixed the tests caused by missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment about the readability of the new splitter, now that I look at it again... 😅
Co-authored-by: Aarni Koskela <akx@iki.fi>
Alright, should be good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a wrap!
Closes #1078
Depends on #1105 (To see only the changes in this PR, look at the last two commits)Since #1105 wraps file names containing white space in special unicode markers, we look out for them when
wrapping comments.
The fix overrides the
_split
method ofTextWrapper
where we manually generate the indivisible chunks, taking intoaccount enclosed file names.
I test the the wrapping behavior with gettext 0.22.5 (which includes the enclosing logic) to make sure it's consistent