-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tin/py311 #973
Merged
Tin/py311 #973
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0911617
Fix test_slots::TestPickle::test_no_getstate_setstate_for_dict_classes
Tinche bff9737
Fix annotations
Tinche 83b2199
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3409360
Tweak tests for 3.10
Tinche d0f9ba1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3ef9236
Tweak tests some more
Tinche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -660,10 +660,12 @@ def test_no_getstate_setstate_for_dict_classes(self): | |
As long as getstate_setstate is None, nothing is done to dict | ||
classes. | ||
""" | ||
i = C1(1, 2) | ||
|
||
assert None is getattr(i, "__getstate__", None) | ||
assert None is getattr(i, "__setstate__", None) | ||
assert getattr(object, "__getstate__", None) is getattr( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
C1, "__getstate__", None | ||
) | ||
assert getattr(object, "__setstate__", None) is getattr( | ||
C1, "__setstate__", None | ||
) | ||
|
||
def test_no_getstate_setstate_if_option_false(self): | ||
""" | ||
|
@@ -674,10 +676,12 @@ def test_no_getstate_setstate_if_option_false(self): | |
class C: | ||
x = attr.ib() | ||
|
||
i = C(42) | ||
|
||
assert None is getattr(i, "__getstate__", None) | ||
assert None is getattr(i, "__setstate__", None) | ||
assert getattr(object, "__getstate__", None) is getattr( | ||
C, "__getstate__", None | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
) | ||
assert getattr(object, "__setstate__", None) is getattr( | ||
C, "__setstate__", None | ||
) | ||
|
||
@pytest.mark.parametrize("cls", [C2(1), C2Slots(1)]) | ||
def test_getstate_set_state_force_true(self, cls): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm this makes no sense to me…this would pass if both don't exist, and if both are the same thing. this doesn't seem like a good test to me :)
maybe have two asserts, depending on version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But... that's what we want. If both don't exist, or both exist and are the same, the functionality is correct. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh…i guess i'll take your word for it? it just seems like there's cases where it passes when it shouldn't 🤔
just merge the other shit in then ¯_(ツ)_/¯