Expose pythnet message buffer idls #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
c6238fa to
28017e5
Compare
|
I understand now. |
guibescos
reviewed
Jun 8, 2023
guibescos
reviewed
Jun 8, 2023
guibescos
reviewed
Jun 8, 2023
guibescos
reviewed
Jun 8, 2023
guibescos
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes message buffer idls that can be further used by xc-admin to init/delete a buffers. Also adds a CI check to ensure that the idls are always up to date.
I changed anchor default package manager from yarn to npm and then I needed to add
skipLibCheckglobally because jest (used in other packages) and mocha (used in Anchor) types are conflicting and can't build together. In the process of adding it to the base tsconfig i realized not all of the packages use that and ran into totally unrelated issue.p.s: One of the issues was
ws-isomorphicpackage behaving differently and resulting in a build error for the price-service-client (weirdly it seems that package-lock hasn't changed anything about it! I think this is because of the tsconfig base "strict" option). Anyway i tested the example to make sure it works fine.