Print inifile and rootdir when there's usage errors #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -669,10 +674,13 @@ def _addoption_instance(self, option, shortupper=False): | |||
|
|
|||
|
|
|||
| class MyOptionParser(argparse.ArgumentParser): | |||
| def __init__(self, parser): | |||
| def __init__(self, parser, extra_info={}): | |||
There was a problem hiding this comment.
Likely not an issue but:
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments
There was a problem hiding this comment.
it should indeed be "extra_info = None" on principle grounds.
|
👍 nice! |
|
Removed the mutable dict from the parameter list as requested. |
33752dc to
8a6aa5e
Compare
|
Rebased on master to account for the mock fix for py26. |
nicoddemus
added a commit
that referenced
this pull request
Jul 11, 2015
Print inifile and rootdir when there's usage errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #821