Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Travis: add pypy3 to allowed failures temporarily #5340

Merged
merged 1 commit into from
May 31, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 30, 2019

Ref: #5334
Ref: #5317

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #5340 into features will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5340      +/-   ##
============================================
+ Coverage      92.4%   93.47%   +1.07%     
============================================
  Files           115      115              
  Lines         26294    26441     +147     
  Branches       2597     2631      +34     
============================================
+ Hits          24297    24716     +419     
+ Misses         1677     1407     -270     
+ Partials        320      318       -2
Impacted Files Coverage Δ
testing/test_tmpdir.py 75.8% <0%> (-23.12%) ⬇️
testing/python/fixtures.py 78.46% <0%> (-12.26%) ⬇️
testing/test_pluginmanager.py 67.37% <0%> (-7.63%) ⬇️
src/_pytest/debugging.py 84.18% <0%> (-5.65%) ⬇️
src/_pytest/tmpdir.py 96.59% <0%> (-3.41%) ⬇️
testing/test_terminal.py 95.64% <0%> (-2.49%) ⬇️
src/_pytest/pytester.py 88.81% <0%> (-0.71%) ⬇️
src/_pytest/config/__init__.py 93.79% <0%> (-0.64%) ⬇️
src/_pytest/fixtures.py 97.79% <0%> (-0.14%) ⬇️
src/_pytest/main.py 96.06% <0%> (+0.21%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10f289...5ac498e. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #5340 into features will increase coverage by 2.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5340      +/-   ##
============================================
+ Coverage      92.4%   95.09%   +2.69%     
============================================
  Files           115      115              
  Lines         26294    26953     +659     
  Branches       2597     2753     +156     
============================================
+ Hits          24297    25632    +1335     
+ Misses         1677     1010     -667     
+ Partials        320      311       -9
Impacted Files Coverage Δ
testing/test_pluginmanager.py 67.37% <0%> (-7.63%) ⬇️
src/_pytest/debugging.py 84.18% <0%> (-5.65%) ⬇️
testing/python/fixtures.py 87.17% <0%> (-3.56%) ⬇️
testing/test_tmpdir.py 97.31% <0%> (-1.62%) ⬇️
src/_pytest/config/__init__.py 93.79% <0%> (-0.64%) ⬇️
testing/conftest.py 100% <0%> (ø) ⬆️
testing/test_cacheprovider.py 99.77% <0%> (+0.03%) ⬆️
src/_pytest/main.py 96.06% <0%> (+0.21%) ⬆️
testing/test_pytester.py 89.29% <0%> (+0.27%) ⬆️
src/_pytest/cacheprovider.py 98.63% <0%> (+0.79%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10f289...5ac498e. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented May 30, 2019

Let's try to fix it instead first.

@blueyed blueyed closed this May 30, 2019
@blueyed blueyed deleted the allow_failures-pypy3 branch May 30, 2019 06:26
@blueyed blueyed restored the allow_failures-pypy3 branch May 31, 2019 00:05
@blueyed blueyed reopened this May 31, 2019
@blueyed
Copy link
Contributor Author

blueyed commented May 31, 2019

Re-opening: #5334 (comment)

@blueyed blueyed requested a review from nicoddemus May 31, 2019 00:05
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit c5de8e8 into pytest-dev:features May 31, 2019
@nicoddemus
Copy link
Member

@asottile we're all set for 4.6. Want to make that release? 😁

@blueyed
Copy link
Contributor Author

blueyed commented May 31, 2019

JFI: this causes Travis builds to become even slower, since it now gets run as the last job: https://travis-ci.org/pytest-dev/pytest/builds/539900223

@blueyed blueyed deleted the allow_failures-pypy3 branch May 31, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants