Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP/RFC: remove pytest.python.Instance [ci skip] #4357

Closed
wants to merge 1 commit into from
Closed

WIP/RFC: remove pytest.python.Instance [ci skip] #4357

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 9, 2018

Ref: #4127

@blueyed blueyed mentioned this pull request Nov 9, 2018
Closed
@blueyed
Copy link
Contributor Author

blueyed commented Nov 9, 2018

Feel free to comment, but let's go with #4358 first.

@blueyed blueyed closed this Nov 9, 2018
@blueyed blueyed deleted the remove-instance branch November 9, 2018 10:12
@nicoddemus
Copy link
Member

Just to note that this is breaking change as pytest.Instance is part of the API. We should figure out a way to deprecate its access somehow if we are to delete it in the future.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus this is one of the changes where i want to do a breaking release without the ramp ups

@nicoddemus
Copy link
Member

Without the ramp ups because there's no sane way to generate a warning for this, correct? I agree, I can't think of a portable way to issue that warning either.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus correct

@blueyed blueyed mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @nicoddemus @RonnyPfannschmidt