Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4243 - support positional argument stacklevel on python2 #4244

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Oct 26, 2018

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #4244 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4244      +/-   ##
==========================================
- Coverage   95.87%   95.86%   -0.01%     
==========================================
  Files         109      109              
  Lines       24590    24597       +7     
  Branches     2392     2394       +2     
==========================================
+ Hits        23575    23580       +5     
- Misses        720      721       +1     
- Partials      295      296       +1
Flag Coverage Δ
#docs 29.04% <38.46%> (-0.02%) ⬇️
#doctesting 29.04% <38.46%> (-0.02%) ⬇️
#linting 29.04% <38.46%> (-0.02%) ⬇️
#linux 95.64% <100%> (-0.01%) ⬇️
#nobyte 92.02% <100%> (+0.64%) ⬆️
#numpy 93.02% <100%> (+51.33%) ⬆️
#pexpect 41.67% <0%> (-0.02%) ⬇️
#py27 94.05% <100%> (ø) ⬆️
#py34 92.34% <30.76%> (+0.14%) ⬆️
#py35 92.35% <30.76%> (+0.02%) ⬆️
#py36 93.98% <30.76%> (-0.02%) ⬇️
#py37 92.36% <30.76%> (+0.02%) ⬆️
#trial 93.02% <100%> (+51.33%) ⬆️
#windows 94.13% <100%> (+0.75%) ⬆️
#xdist 93.89% <100%> (+0.15%) ⬆️
Impacted Files Coverage Δ
testing/test_recwarn.py 99.56% <100%> (ø) ⬆️
src/_pytest/recwarn.py 98.31% <100%> (+0.04%) ⬆️
src/_pytest/capture.py 93.39% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041044e...ce0b051. Read the comment docs.

@nicoddemus nicoddemus merged commit 56989a8 into pytest-dev:master Oct 26, 2018
@nicoddemus
Copy link
Member

Thanks

@RonnyPfannschmidt RonnyPfannschmidt deleted the fix-4243 branch November 30, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants