Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3491 - Fixed a bug where stdout and stderr were logged twice by junitxml for xfail tests. #3499

Merged
merged 3 commits into from
May 24, 2018

Conversation

jeffreyrack
Copy link
Member

Before this commit. stdout and stderr were being logged twice in the junitxml report.

This change fixes the issue so that stdout and stderr are now only logged once:

<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="0" name="pytest" skips="1" tests="1" time="0.062">
	<testcase classname="test" file="test.py" line="3" name="test_fail" time="0.0">
	<skipped message="expected test failure"></skipped>
	<system-out>XFAIL This is stdout
	</system-out>
	<system-err>XFAIL This is stderr
	</system-err>
	</testcase>
</testsuite>

@coveralls
Copy link

coveralls commented May 24, 2018

Coverage Status

Coverage increased (+0.05%) to 92.742% when pulling b4e0265 on jeffreyrack:3491-junit-logging into afde9f0 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@nicoddemus
Copy link
Member

@jeffreyrack a quick tip: if you put Fix #<issue> in the body of the PR, it will close the issue automatically when it gets merged. 😉

You can read more about it here.

Thanks again for the PR!

@jeffreyrack jeffreyrack deleted the 3491-junit-logging branch April 4, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants