change collections.abc import to fix deprecation warnings on python 3.7 #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@irmen thanks! I checked out your fork to fix the linting issues myself, but then realized that the imports should go into Thanks! |
|
And oops, I realized I switched the versions. 😅 I will push another commit in a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deprecation warnings from Python 3.7 related to importing abcs from the collections module, mentioned in issue #3339
I couldn't fix the same for using the deprecated
impmodule, there's a bit too much wizardry going on with it in _pytest/assertion/rewrite.py ...