Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use flush in order to avoid hanging on mac #3116

Merged
merged 2 commits into from
Jan 23, 2018
Merged

use flush in order to avoid hanging on mac #3116

merged 2 commits into from
Jan 23, 2018

Conversation

brianmaissy
Copy link
Contributor

@brianmaissy brianmaissy commented Jan 14, 2018 •
edited
Loading

Fixes #2022

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.558% when pulling 0a0d97a on brianmaissy:pexpect_test_hangs_on_mac into 3181718 on pytest-dev:master.

@nicoddemus
Copy link
Member

I don't have a Mac to check this myself, but I trust @brianmaissy has tested it himself and the change in the PR works. 😁

@nicoddemus nicoddemus merged commit ff90c9e into pytest-dev:master Jan 23, 2018
@brianmaissy brianmaissy mentioned this pull request Jan 25, 2018
Closed
@brianmaissy brianmaissy deleted the pexpect_test_hangs_on_mac branch January 27, 2018 21:04
@blueyed blueyed mentioned this pull request Apr 7, 2019
Closed
@blueyed
Copy link
Contributor

blueyed commented May 27, 2019

Well, #2022 indicated that it should rather read everything (non-blocking) instead of calling wait().

Currently it causes tests to not have a returncode then. Working on that in #5313.

@blueyed
Copy link
Contributor

blueyed commented May 27, 2019

Yeah, it turns out that it should read() here before wait()ing.
#5313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pexpect tests hang on macOS
4 participants
@brianmaissy @coveralls @nicoddemus @blueyed