Vendoring tasks #2523
Merged
Vendoring tasks #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f135f99 to
2469527
Compare
nicoddemus
requested changes
Jun 23, 2017
changelog/2474.trivial
Outdated
| @@ -0,0 +1 @@ | |||
| create invoke tasks for updating the vendored packages | |||
There was a problem hiding this comment.
Please use proper grammar here. 😉
Create invoke tasks for updating the vendored packages.
|
|
||
| @invoke.task(pre=[remove_libs]) | ||
| def update_libs(ctx): | ||
| print("installing libs") |
There was a problem hiding this comment.
I think it makes sense to call remove_libs automatically first.
There was a problem hiding this comment.
it is ^^ - as pre task
There was a problem hiding this comment.
Oops completely missed that. 😅
tasks/vendoring.py
Outdated
| print("installing libs") | ||
| ctx.run("pip install -t {target} pluggy".format(target=VENDOR_TARGET)) | ||
| ctx.run("git add {target}".format(target=VENDOR_TARGET)) | ||
| print("please commit to finish the updae after running the tests") |
There was a problem hiding this comment.
I suggest also outputting a suggestion for the commit message, so it is standardized:
print("Please commit to finish the updae after running the tests:")
print()
print(' git commit -am "Updated vendored libs"')4c785f1 to
68811f5
Compare
68811f5 to
b3bf7fc
Compare
nicoddemus
approved these changes
Jun 23, 2017
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2474