Add __future__ imports to all pytest modules #2316
Conversation
This prevents silly errors from creeping in Python 2 when testing in Python 3
| @@ -1,4 +1,4 @@ | |||
| from __future__ import generators | |||
| from __future__ import absolute_import, division, generators, print_function | |||
There was a problem hiding this comment.
generators is not needed since python 2.3 - we may just want to remove it already ^^
There was a problem hiding this comment.
That was my initial reaction and did remove it, but to my surprise that import is actually used:
def compile(self, filename=None, mode='exec',
flag=generators.compiler_flag,
dont_inherit=0, _genframe=None):I did take a quick look at the docs for an alternative but couldn't find any, so decided to just let it be. Do you have a suggestion?
There was a problem hiding this comment.
@nicoddemus that seems to be there exactly to support generators on old python versions, i think it can be disabled - perhaps we can even remove the parameter
There was a problem hiding this comment.
@nicoddemus in fact - the place where its used suggests incredibly bad api because any external user would pass wrong flags unless being told about the behavior of the default
There was a problem hiding this comment.
I agree, but I think that refactoring would be out of scope for this PR, don't you agree?
There was a problem hiding this comment.
true, we should make an issue about it i think
This prevents silly errors from creeping in Python 2 when testing in Python 3.
Noticed this while working on the "pytest warnings" branch and things failed horribly on Python 2 because the module is named
warnings.py. Thought about renaming it, but thought "hey it's 2017 we shouldn't worry about this type of silly error anymore". 😉While at it:
py.builtin.print_calls by nativeprint()calls;CONTRIBUTIONcould use an update and recommend testing withpy36;