Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit warnings for legacy parametrization + marking #2427

Closed
The-Compiler opened this issue May 23, 2017 · 0 comments
Closed

Emit warnings for legacy parametrization + marking #2427

The-Compiler opened this issue May 23, 2017 · 0 comments
Assignees
@RonnyPfannschmidt
Labels
type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch

Comments

@The-Compiler
Copy link
Member

The-Compiler commented May 23, 2017 •
edited
Loading

In #1921 we say "The old syntax will be removed in pytest-4.0.", and @nicoddemus said "Also please state that this mechanism will start to emit warnings in 3.1 and will be dropped in 4.0.".

However, looks like this hasn't happened.

As a quick hack for myself I did this in ParameterSet.extract_from:

        while isinstance(argval, MarkDecorator):
            assert False, parameterset  # added

cc @RonnyPfannschmidt
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this May 23, 2017
@nicoddemus nicoddemus added the type: feature-branch new feature or API change, should be merged into features branch label May 24, 2017
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jun 23, 2017
@RonnyPfannschmidt
introduce deprecation warnings for legacy parametersets, fixes pytest…
37c8bd8 
…-dev#2427
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jun 23, 2017
@RonnyPfannschmidt
introduce deprecation warnings for legacy parametersets, fixes pytest…
0d0b01b 
…-dev#2427
nicoddemus added a commit that referenced this issue Jun 24, 2017
@nicoddemus
Merge pull request #2524 from RonnyPfannschmidt/fix-2427
1906f8c 
introduce deprecation warnings for legacy parametersets, fixes #2427
@nicoddemus nicoddemus mentioned this issue Jul 18, 2017
Closed
@nicoddemus nicoddemus added type: enhancement new feature or API change, should be merged into features branch and removed type: enhancement new feature or API change, should be merged into features branch labels Sep 14, 2017
@nicoddemus nicoddemus mentioned this issue Jan 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

Labels
type: enhancement new feature or API change, should be merged into features branch type: feature-branch new feature or API change, should be merged into features branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RonnyPfannschmidt @The-Compiler @nicoddemus