Don't create DSession in collect-only mode #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested changes
Sep 4, 2017
xdist/plugin.py
Outdated
| config.pluginmanager.register(session, "dsession") | ||
| tr = config.pluginmanager.getplugin("terminalreporter") | ||
| tr.showfspath = False | ||
| if config.getoption("boxed"): |
There was a problem hiding this comment.
this "incorrectly" disaables the aliasing of boxed to forked,
it just doesn't show because collectonly doesnt run any tests
Re-enable parsing of the boxed option with collect-only
RonnyPfannschmidt
approved these changes
Sep 7, 2017
|
I've added an acceptance test and some unit tests in test_plugin. I've also re-enable the boxed option with collect-only even though it has no effect since no tests are run. |
|
well done will merge after pass |
|
flake8 strikes again ^^ |
|
Oops, sorry! |
|
don't worry, i suffer the same fate way to regular ^^ |
| @@ -44,6 +44,36 @@ def test_auto_detect_cpus(testdir, monkeypatch): | |||
| assert config.getoption('numprocesses') == 99 | |||
|
|
|||
|
|
|||
| def test_boxed_with_collect_only(testdir): | |||
There was a problem hiding this comment.
i would consider that on unnecessary - forked/boxed got removed from xdist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
Make sure to include reasonable tests for your change if necessary
We use towncrier for changelog management, so please add a news file into the
changelogfolder following these guidelines:Name it
$issue_id.$typefor example588.bugfix;If you don't have an issue_id change it to the PR id after creating it
Ensure type is one of
removal,feature,bugfix,vendor,docortrivialMake sure to use full sentences with correct case and punctuation, for example: