Fix CI linting workflow #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing. The tox "lint" target expects Python 3.10 to be installed, but CI only installs Python 3.9. skip_missing_interpreters caused the "lint" workflow in CI to exit successfully, even though no linting was performed. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…ox configuration. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…onments of a GitHub actions run. Linting is performed explicitly in a separate workflow and does not need to be run as part of the Python 3.9 tests. Additionally, linting currently expects Python 3.10 and will fail during the Python 3.9 test run. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
The lint environment requires mypy from the test dependencies to be installed. Although the environment defines `extras = testing`, it also specifies `skip_install = true`, which also skips installation of test dependencies. This change removes skip_install = true, so that mypy is installed correctly. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
… "version-info" environment. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Tinche
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tox "lint" target expects Python 3.10 to be installed, but CI only installs Python 3.9. The
skip_missing_interpretersconfiguration caused the "lint" workflow in CI to exit successfully, even though no linting was performed.This PR:
Removes the
skip_missing_interpretersto prevent silent errors in the future.Installs the required Python version during the lint workflow
Removes tox's "lint" environment from the set of "3.9" environments of a GitHub actions run.
Linting is performed explicitly in a separate workflow and does not need to be run as part of the Python 3.9 tests. Additionally, linting currently expects Python 3.10 and will fail during the Python 3.9 test run.
Fixes a bug that prevented mypy to be installed correctly for tox's "lint" environment
The lint environment requires mypy from the test dependencies to be installed. Although the environment defines
extras = testing, it also specifiesskip_install = true, which also skips installation of test dependencies.