Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Switch to importlib-metadata" #206

Merged
merged 2 commits into from
May 7, 2019
Merged

Revert "Switch to importlib-metadata" #206

merged 2 commits into from
May 7, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented May 7, 2019

Reverts #199

Fixes #205

nicoddemus
nicoddemus approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response!

nicoddemus
nicoddemus reviewed May 7, 2019
View reviewed changes
@nicoddemus
Copy link
Member

@asottile would you mind preparing 0.10.1 after this gets merged (see HOWTORELEASE)?

@nicoddemus
Copy link
Member

Hmmm actually I think we should release 0.11.0, given that we are dropping a dependency... 🤔

@asottile
Copy link
Member Author

asottile commented May 7, 2019

@asottile would you mind preparing 0.10.1 after this gets merged (see HOWTORELEASE)?

I don't have the merge bit on this project so I can't complete any step beyond step 2

@nicoddemus
Copy link
Member

I don't have the merge bit on this project

Fixed. 😉

@asottile
Copy link
Member Author

asottile commented May 7, 2019

yep will do, 0.11.0 sounds good to me, version numbers are free after all :)

@asottile asottile merged commit 07f4434 into pytest-dev:master May 7, 2019
@asottile asottile deleted the revert-199-importlib_metadata_v2 branch May 7, 2019 15:20
@Lawouach
Copy link

Lawouach commented May 7, 2019

Thanks a bunch folks. Much appreciated as I was going crazy in dependency hells between pluggy, pytest and pytest-* plugins all requiring different versions :)

@blueyed
Copy link
Contributor

blueyed commented May 7, 2019

FWIW, it also breaks pytest's builds (on master) - just noticed this and wondered what's up..

@asottile
Copy link
Member Author

asottile commented May 7, 2019

FWIW, it also breaks pytest's builds (on master) - just noticed this and wondered what's up..

yes, that was intentional -- pytest monkeypatches internal implementation details of pluggy -- that was addressed in the pluggy-specifig upgrade PR: pytest-dev/pytest#5063 -- those breaks were in tests only and the actual functionality is fine

asottile added a commit that referenced this pull request May 25, 2019
@asottile
Revert "Merge pull request #206 from asottile/revert-199-importlib_me…
b0f3b6d 
…tadata_v2"

This reverts commit 07f4434, reversing
changes made to d7a9792.
@asottile asottile mentioned this pull request May 25, 2019
Merged
@asottile
Copy link
Member Author

#215 reverts this revert now that importlib-metadata supports eggs upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

importlib_metadata breaks TravisCI builds
4 participants
@asottile @nicoddemus @Lawouach @blueyed