Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Total Inflow Volume #93

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Conversation

bemcdonnell
Copy link
Member

Closes #92

@bemcdonnell bemcdonnell added this to the v5.2.0 milestone Sep 19, 2017
@bemcdonnell bemcdonnell self-assigned this Sep 19, 2017
Copy link

@michaeltryby michaeltryby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work @bemcdonnell ! Perhaps we can think about structuring a Report API for organizing the function calls that group together and access variables commonly found in the text report file. What do you think?

@bemcdonnell
Copy link
Member Author

@michaeltryby, Yeah we should roadmap this thing pretty soon before it gets out of control

@bemcdonnell bemcdonnell merged commit 2655e99 into pyswmm:develop Sep 20, 2017
@bemcdonnell bemcdonnell deleted the outfallloadfix branch September 20, 2017 00:55
bemcdonnell pushed a commit that referenced this pull request Jan 1, 2023
Use vcpkg for boost-test dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants