Added simple support for Thread Count setter - partially tested #394
Conversation
There was a problem hiding this comment.
We should check after the simulation using massbal_getRoutingTotal to check if the threads are set.
Also, I assume this will overwrite the Threads from INP file.
There was a problem hiding this comment.
We should also make sure INP threads are retained with this addition. We should add a test to make sure swmm_setSimulationParam is reading the threads set in the INP file.
There was a problem hiding this comment.
Also, Mac probably needs to revert to an older version of the OS supported by actions.
There was a problem hiding this comment.
@abhiramm7 when project.c parses the INP file the THREADS are first set there. This feature only avails that change if the user wants to change it through the API. We also set the same limits / rules as the project.c has.. (>=1 and <= Max Threads Available). The mac build finally ran and it checks out
tests/solver/test_toolkit.cpp
Outdated
|
|
||
| #if defined(_OPENMP) | ||
| error = swmm_setSimulationParam(SM_THREADS, 2); | ||
| error = swmm_setSimulationParam(SM_THREADS, &value); |
There was a problem hiding this comment.
@bemcdonnell, can we change line 429 to use swmm_getSimulationParam? I think you are trying to set the param, then check that it was set properly, but I'm not sure the code does this currently.
There was a problem hiding this comment.
OOOF good catch!!!! Doing that now
Closes #172
Interested in seeing how the unit tests play out.