Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no-detach detatching #1274

Merged
merged 21 commits into from
Mar 22, 2024
Merged

fix: no-detach detatching #1274

merged 21 commits into from
Mar 22, 2024

Conversation

port19x
Copy link
Collaborator

@port19x port19x commented Feb 4, 2024

@port19x port19x requested a review from Derisis13 as a code owner February 4, 2024 20:11
@port19x
Copy link
Collaborator Author

port19x commented Feb 4, 2024

I think shellcheck is a little confused here

@germaniuss
Copy link

Just tested out this MR and it does not seem to work. I feel like not redirecting the mpv output to /dev/null is necessary since when used with the kitty protocol the frames are sent through a bytestream from mpv to the terminal.

@germaniuss
Copy link

Just tested out this MR and it does not seem to work. I feel like not redirecting the mpv output to /dev/null is necessary since when used with the kitty protocol the frames are sent through a bytestream from mpv to the terminal.

By not work, I mean that the video is not showing. I no longer need to pkill the mpv process since it does not detach anymore, but the kitty protocol messages are not redirected to the terminal.

@port19x
Copy link
Collaborator Author

port19x commented Feb 8, 2024

fixed, please try again to verify

@germaniuss
Copy link

Well that was fast haha, it does work now!!

@port19x
Copy link
Collaborator Author

port19x commented Feb 8, 2024

On vacation doing some random coding currently :D

@port19x port19x changed the title fix: no-detach was incomplete fix: no-detach detatching Feb 8, 2024
Copy link
Collaborator

@Derisis13 Derisis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good. Shouldn't shellcheck catch this one?

@Derisis13
Copy link
Collaborator

oh wait, it did

@port19x port19x merged commit 63b7b9e into master Mar 22, 2024
6 checks passed
@port19x port19x deleted the fix-nodetach branch March 22, 2024 06:39
@port19x
Copy link
Collaborator Author

port19x commented Mar 22, 2024

Yeah, I wanted to be smart, but shellcheck didn't let me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants