Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] pseudo-p significance calculation #281
base: main
Are you sure you want to change the base?
[Draft] pseudo-p significance calculation #281
Changes from 7 commits
9b80c2f
5e6b05b
1783ae9
65552ca
920719c
d9ea095
c6e3a8a
fa2deaa
1c59fa7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 2 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L1-L2
Check warning on line 5 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L5
Check warning on line 28 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L26-L28
Check warning on line 33 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L30-L33
Check warning on line 35 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L35
Check warning on line 39 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L39
Check warning on line 45 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L43-L45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be able to be vectorised, but I couldn't quickly figure that out. the following did not generate the same results as below:
Check warning on line 54 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L52-L54
Check warning on line 59 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L56-L59
Check warning on line 63 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L63
Check warning on line 66 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L66
Check warning on line 74 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L70-L74
Check warning on line 80 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L76-L80
Check warning on line 86 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L82-L86
Check warning on line 88 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L88
Check warning on line 92 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L92
Check warning on line 96 in esda/significance.py
Codecov / codecov/patch
esda/significance.py#L96